Re: [Qemu-devel] [PATCH RESEND v6 00/12] virtio-crypto: introduce framework and device emulation

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH RESEND v6 00/12] virtio-crypto: introduce 
framework and device emulation
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
47cfbc1 virtio-crypto: perfect algorithms chainning support
81a4d12 virtio-crypto: add myself as virtio-crypto and cryptodev backends 
maintainer
7ad32b1 cryptodev: introduce an unified wrapper for crypto operation
4714b3d virtio-crypto: add data queue processing handler
b61dfe7 virtio-crypto: add control queue handler
8b91458 virtio-crypto: set capacity of algorithms supported
c0f4d06 virtio-crypto-pci: add virtio crypto pci support
a7e5efe virtio-crypto: add virtio crypto device emulation
727ff7f cryptodev: introduce a new cryptodev backend
a7db317 virtio-crypto: introduce virtio_crypto.h
c2324a0 cryptodev: add symmetric algorithm operation stuff
a302606 cryptodev: introduce cryptodev backend interface

=== OUTPUT BEGIN ===
Checking PATCH 1/12: cryptodev: introduce cryptodev backend interface...
Checking PATCH 2/12: cryptodev: add symmetric algorithm operation stuff...
Checking PATCH 3/12: virtio-crypto: introduce virtio_crypto.h...
Checking PATCH 4/12: cryptodev: introduce a new cryptodev backend...
Checking PATCH 5/12: virtio-crypto: add virtio crypto device emulation...
Checking PATCH 6/12: virtio-crypto-pci: add virtio crypto pci support...
Checking PATCH 7/12: virtio-crypto: set capacity of algorithms supported...
Checking PATCH 8/12: virtio-crypto: add control queue handler...
Checking PATCH 9/12: virtio-crypto: add data queue processing handler...
ERROR: open brace '{' following struct go on the same line
#382: FILE: include/hw/virtio/virtio-crypto.h:41:
+struct virtio_crypto_inhdr
+{

total: 1 errors, 0 warnings, 373 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/12: cryptodev: introduce an unified wrapper for crypto 
operation...
Checking PATCH 11/12: virtio-crypto: add myself as virtio-crypto and cryptodev 
backends maintainer...
Checking PATCH 12/12: virtio-crypto: perfect algorithms chainning support...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden