[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/29] target-sparc: simplify ultrasparc_tsb_poi
From: |
Artyom Tarasenko |
Subject: |
Re: [Qemu-devel] [PATCH 20/29] target-sparc: simplify ultrasparc_tsb_pointer |
Date: |
Tue, 11 Oct 2016 16:08:53 +0200 |
On Tue, Oct 11, 2016 at 4:05 PM, Richard Henderson <address@hidden> wrote:
> On 10/01/2016 05:05 AM, Artyom Tarasenko wrote:
>>
>> Signed-off-by: Artyom Tarasenko <address@hidden>
>> ---
>> target-sparc/ldst_helper.c | 51
>> ++++++++++++++--------------------------------
>> 1 file changed, 15 insertions(+), 36 deletions(-)
>
>
> Perhaps this should be folded with patch 19.
>
>> +static uint64_t ultrasparc_tsb_pointer(CPUSPARCState *env, SparcV9MMU
>> mmu,
>> + int idx)
>
>
> Did you really mean to pass the whole mmu structure by value? That's 16
> words that need to be copied to perform this call. I'm sure it would be
> better to pass by (const?) reference.
Indeed. Thanks.
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
- Re: [Qemu-devel] [PATCH 16/29] target-sparc: ignore writes to UA2005 CPU mondo queue register, (continued)
- [Qemu-devel] [PATCH 17/29] target-sparc: replace the last tlb entry when no free entries left, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 18/29] target-sparc: use SparcV9MMU type for sparc64 I/D-MMUs, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 19/29] target-sparc: implement UA2005 TSB Pointers, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 21/29] target-sparc: allow 256M sized pages, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 20/29] target-sparc: simplify ultrasparc_tsb_pointer, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 22/29] target-sparc: implement auto-demapping for UA2005 CPUs, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 24/29] target-sparc: add more registers to dump_mmu, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 23/29] target-sparc: implement ST_BLKINIT_ ASIs, Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 25/29] target-sparc: implement UA2005 ASI_MMU (0x21), Artyom Tarasenko, 2016/10/01
- [Qemu-devel] [PATCH 26/29] target-sparc: store the UA2005 entries in sun4u format, Artyom Tarasenko, 2016/10/01