Re: [Qemu-devel] [PATCH 29/29] target-sparc: fix up Niagara machine

[Richard Henderson]

On 10/01/2016 05:05 AM, Artyom Tarasenko wrote:
> Remove the Niagara stub implementation from sun4u.c and add a machine,
> compatible with Legion simulator from the OpenSPARC T1 project.
>
> The machine uses the firmware supplied with the OpenSPARC T1 project,
> http://download.oracle.com/technetwork/systems/opensparc/OpenSPARCT1_Arch.1.5.tar.bz2
> in the directory S10image/, and is able to boot the supplied Solaris 10 image.
>
> Signed-off-by: Artyom Tarasenko <address@hidden>

Reviewed-by: Richard Henderson <address@hidden>

What do you plan to do about the roms?  Since they're open source, I don't see 
any reason we couldn't commit them into pc-bios/.  Of course if we do that ...

> +    rom_add_file_fixed("nvram1", NIAGARA_NVRAM_BASE, -1);
> +    rom_add_file_fixed("1up-md.bin", NIAGARA_MD_ROM_BASE, -1);
> +    rom_add_file_fixed("1up-hv.bin", NIAGARA_HV_ROM_BASE, -1);
> +
> +    rom_add_file_fixed("reset.bin", NIAGARA_PROM_BASE, -1);
> +    rom_add_file_fixed("q.bin", NIAGARA_PROM_BASE + NIAGARA_Q_OFFSET, -1);
> +    rom_add_file_fixed("openboot.bin", NIAGARA_PROM_BASE + NIAGARA_OBP_OFFSET,
> +                       -1);

... these would surely need better names.


r~