[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option |
Date: |
Tue, 11 Oct 2016 20:20:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> This option does nothing since commit 06ac27f. Deprecate it.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> vl.c | 11 +++--------
> include/monitor/monitor.h | 2 +-
> qemu-options.hx | 8 ++++----
> 3 files changed, 8 insertions(+), 13 deletions(-)
>
> v2:
> - update after Markus review
> - fix error on default monitor
> - drop from qemu-trivial
Suggest to squash in the appended patch.
Reviewed-by: Markus Armbruster <address@hidden>
Could go via David, Paolo or myself. David, do you have anything
pending right now?
diff --git a/monitor.c b/monitor.c
index b07f254..ab9e911 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4093,7 +4093,7 @@ QemuOptsList qemu_mon_opts = {
.name = "chardev",
.type = QEMU_OPT_STRING,
},{
- .name = "default",
+ .name = "default", /* deprecated */
.type = QEMU_OPT_BOOL,
},{
.name = "pretty",