Re: [Qemu-devel] [PATCHv2 0/7] Improve PCI IO window orgnaization for pseries

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCHv2 0/7] Improve PCI IO window orgnaization for 
pseries
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
48ea719 spapr: Improved placement of PCI host bridges in guest memory map
f790c9b spapr_pci: Add a 64-bit MMIO window
d062e05 spapr: Adjust placement of PCI host bridge to allow > 1TiB RAM
05496d4 spapr_pci: Delegate placement of PCI host bridges to machine type
b786bfb libqos: Limit spapr-pci to 32-bit MMIO for now
3f60afe libqos: Correct error in PCI hole sizing for spapr
150ef26 libqos: Isolate knowledge of spapr memory map to qpci_init_spapr()

=== OUTPUT BEGIN ===
Checking PATCH 1/7: libqos: Isolate knowledge of spapr memory map to 
qpci_init_spapr()...
Checking PATCH 2/7: libqos: Correct error in PCI hole sizing for spapr...
Checking PATCH 3/7: libqos: Limit spapr-pci to 32-bit MMIO for now...
Checking PATCH 4/7: spapr_pci: Delegate placement of PCI host bridges to 
machine type...
Checking PATCH 5/7: spapr: Adjust placement of PCI host bridge to allow > 1TiB 
RAM...
Checking PATCH 6/7: spapr_pci: Add a 64-bit MMIO window...
Checking PATCH 7/7: spapr: Improved placement of PCI host bridges in guest 
memory map...
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#142: FILE: hw/ppc/spapr.c:2534:
+#define SPAPR_COMPAT_2_7                            \
+    HW_COMPAT_2_7                                   \
+    {                                               \
+        .driver   = TYPE_SPAPR_PCI_HOST_BRIDGE,     \
+        .property = "mem_win_size",                 \
+        .value    = stringify(SPAPR_PCI_2_7_MMIO_WIN_SIZE),\
+    },                                              \
+    {                                               \
+        .driver   = TYPE_SPAPR_PCI_HOST_BRIDGE,     \
+        .property = "mem64_win_size",               \
+        .value    = "0",                            \
+    },

total: 1 errors, 0 warnings, 226 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden