[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes i
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start() |
|
Date: |
Wed, 12 Oct 2016 16:06:56 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben:
> When block-commit is launched without the top parameter, it uses
> internally a mirror block job. In that case all intermediate nodes
> between the active and base nodes must be blocked as well.
>
> Signed-off-by: Alberto Garcia <address@hidden>
Same as the patch before, dataplane is okay because AioContexts are
switched together with the source image.
On second thought, however, maybe both places should set a blocker that
prevents attaching intermediate nodes to a new block device because you
can't read consistent data there. That's a preexisting problem, though,
and needs its own patch.
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, (continued)
- Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, Kevin Wolf, 2016/10/12
- Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, Alberto Garcia, 2016/10/12
- Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, Markus Armbruster, 2016/10/11
- Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, Alberto Garcia, 2016/10/12
- Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, Markus Armbruster, 2016/10/12
Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, Kevin Wolf, 2016/10/12
[Qemu-devel] [PATCH v10 06/16] block: Block all nodes involved in the block-commit operation, Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start(), Alberto Garcia, 2016/10/06
- Re: [Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start(),
Kevin Wolf <=
[Qemu-devel] [PATCH v10 02/16] block: Add block_job_add_bdrv(), Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer, Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple(), Alberto Garcia, 2016/10/06