|
From: | Michael Walle |
Subject: | Re: [Qemu-devel] [PATCH] target-lm32: fix style issue |
Date: | Wed, 12 Oct 2016 18:42:09 +0200 |
User-agent: | Roundcube Webmail/1.1.5 |
Am 2016-10-12 18:35, schrieb Peter Maydell:
but I noticed while doing the review that our LOG_DIS is wrong for the compare-immediates: LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, sign_extend(dc->imm16, 16)); but the processor reference manual says cmpei's mnemonic should have dc->r1 first and dc->r0 second. (Similarly for the logging for the other immediate compares.)
Argh, you're eyes are too good ;) I'll have a look. -michael
[Prev in Thread] | Current Thread | [Next in Thread] |