[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour |
Date: |
Wed, 12 Oct 2016 18:48:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 12/10/2016 15:55, Claudio Imbrenda wrote:
>>>> >>> + for (cx = 0; ccpus && ccpus[cx]; cx++) {
>>>> >>> + cpu_single_step(cpu, 0);
>> >
>> > This looks suspicious
> why? we set all cpus to single step, since that is the default, and then
> we clear the single-step property from all CPUs that should be restarted
> in normal mode, then we restart all CPUs. Those in single-step will
> indeed only perform one single step, the others will run freely (at
> least until the first single-step CPU stops again).
>
Yeah, it makes sense.
Paolo
- Re: [Qemu-devel] [PATCH v1 1/2] gdbstub: Fix single-step, (continued)
[Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour, Claudio Imbrenda, 2016/10/10