qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 6/9] qdev: remove call to qemu_chr_add_handlers()


From: Marc-André Lureau
Subject: [Qemu-devel] [PATCH 6/9] qdev: remove call to qemu_chr_add_handlers()
Date: Thu, 13 Oct 2016 15:14:46 +0400

chardev property is blindly trying to remove the frontend handlers, but
that doesn't work properly that way since there might be several
frontend on the same chardev. Instead, chardev frontend should use
qemu_chr_remove_handlers(). A previous commit should have fixed all
users.

Signed-off-by: Marc-André Lureau <address@hidden>
---
 hw/core/qdev-properties-system.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index e55afe6..73d4482 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -185,7 +185,6 @@ static void release_chr(Object *obj, const char *name, void 
*opaque)
     CharDriverState *chr = *ptr;
 
     if (chr) {
-        qemu_chr_add_handlers(chr, NULL, NULL, NULL, NULL);
         qemu_chr_fe_release(chr);
     }
 }
-- 
2.10.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]