[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/15] xen: Fix coding style warnings
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH 02/15] xen: Fix coding style warnings |
Date: |
Thu, 13 Oct 2016 12:35:36 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Thu, Oct 13, 2016 at 07:04:56AM +0300, Emil Condrea wrote:
> On Tue, Oct 11, 2016 at 5:20 PM, Anthony PERARD
> <address@hidden> wrote:
> > On Tue, Oct 04, 2016 at 09:43:31AM +0300, Emil Condrea wrote:
> >> Fixes:
> >> * WARNING: line over 80 characters
> >>
> >> Signed-off-by: Emil Condrea <address@hidden>
> >> ---
> >> hw/block/xen_disk.c | 3 ++-
> >> hw/char/xen_console.c | 6 ++++--
> >> hw/display/xenfb.c | 30 ++++++++++++++++++++----------
> >> hw/net/xen_nic.c | 12 ++++++++----
> >> hw/xen/xen_backend.c | 15 ++++++++++-----
> >> include/hw/xen/xen_backend.h | 8 +++++---
> >> 6 files changed, 49 insertions(+), 25 deletions(-)
> >>
> >> diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
> >> index 5aa350a..24edeb2 100644
> >> --- a/hw/block/xen_disk.c
> >> +++ b/hw/block/xen_disk.c
> >> @@ -1068,7 +1068,8 @@ static int blk_connect(struct XenDevice *xendev)
> >> blk_set_enable_write_cache(blkdev->blk, !writethrough);
> >> } else {
> >> /* setup via qemu cmdline -> already setup for us */
> >> - xen_be_printf(&blkdev->xendev, 2, "get configured bdrv (cmdline
> >> setup)\n");
> >> + xen_be_printf(&blkdev->xendev, 2,
> >> + "get configured bdrv (cmdline setup)\n");
> >
> > Arguments are usually aligned with the first one, so there is one
> > missing space.
>
> I guess this is displayed wrongly in the email client as in mine but the
> source
> of the email contains this patch http://pastebin.com/Sbk23h6m, which shows
> that
> this line is aligned to the first parameter.
My mail client runs in a terminal, also I've apply the patches to a
local tree, so no display issue.
Here, the quote is just below the open parentheses, but it's normally
one space futher.
If I ask Vim to realign it, I end up with this:
xen_be_printf(&blkdev->xendev, 2,
- "get configured bdrv (cmdline setup)\n");
+ "get configured bdrv (cmdline setup)\n");
You can also have a look at other call of xen_be_printf() in this
function (blk_connect) to get an idea ;).
--
Anthony PERARD
[Qemu-devel] [PATCH 06/15] xen: Move evtchn functions to xen_pvdev.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 03/15] xen: Create a new file xen_pvdev.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 05/15] xen: Move xenstore_update to xen_pvdev.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 04/15] xen: Create a new file xen_frontend.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 07/15] xen: Prepare xendev qtail to be shared with frontends, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 08/15] xen: Move xenstore cleanup and mkdir functions, Emil Condrea, 2016/10/04