[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machi
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names |
Date: |
Thu, 13 Oct 2016 14:47:03 -0300 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote:
> machine_set_property() replaces '_' by '-' in the property name.
> Except it fails to replace an initial '_'. Screwed up in commit
> b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property
> '._-foo-bar' not found".
>
> Error messages using a mangled name rather than the name the user
> actually wrote is user-hostile, but that's a different topic.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Applied to machine-next. Thanks.
--
Eduardo
Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names,
Eduardo Habkost <=