Re: [Qemu-devel] [PATCH] replication: interrupt failover if the main device is closed

[Stefan Hajnoczi]

On Fri, Oct 07, 2016 at 02:21:33PM +0200, Paolo Bonzini wrote:
> Without this change, there is a race condition in tests/test-replication.
> Depending on how fast the failover job (active commit) runs, there is a
> chance of two bad things happening:
> 
> 1) replication_done can be called after the secondary has been closed
> and hence when the BDRVReplicationState is not valid anymore.
> 
> 2) two copies of the active disk are present during the
> /replication/secondary/stop test (that test runs immediately after
> /replication/secondary/start, which tests failover).  This causes the
> corruption detector to fire.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  block/replication.c | 3 +++
>  1 file changed, 3 insertions(+)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

signature.asc
Description: PGP signature