Re: [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

[Paolo Bonzini]

> +#ifdef CONFIG_ICONV
> +    if (font_charset) {
> +        unsigned char ch;
> +        wchar_t wch;
> +        char *pch, *pwch;
> +        size_t sch, swch;
> +        iconv_t conv;
> +
> +        conv = iconv_open("WCHAR_T", font_charset);

Is this portable?  It seems safer to convert to UTF-8 and parse the
resulting character (assuming that wchar_t is Unicode).  There is
already mod_utf8_codepoint for this task.

Paolo