|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v6 13/35] tcg: Add atomic helpers |
Date: | Sun, 16 Oct 2016 18:40:05 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/16/2016 03:17 PM, Emilio G. Cota wrote:
+#if DATA_SIZE == 1 > +# define END > +#elif defined(HOST_WORDS_BIGENDIAN) > +# define END _be > +#else > +# define END _le > +#endifIt took me a while to figure out that ATOMIC_NAME needs END (ATOMIC_NAME is defined later in the patch). It might be clearer to pass it explicitly as a suffix in the macro, as in #define ATOMIC_NAME(name, suffix) to then have ATOMIC_NAME(cmpxchg, END).
Hum. Perhaps a comment? r~
[Prev in Thread] | Current Thread | [Next in Thread] |