[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/35] cmpxchg-based emulation of atomics
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/35] cmpxchg-based emulation of atomics |
Date: |
Mon, 17 Oct 2016 16:33:59 +0100 |
User-agent: |
mu4e 0.9.17; emacs 25.1.50.9 |
Richard Henderson <address@hidden> writes:
> On 10/17/2016 01:17 AM, Alex Bennée wrote:
>>
>> Emilio G. Cota <address@hidden> writes:
>>
>>> On Tue, Oct 11, 2016 at 14:40:26 -0500, Richard Henderson wrote:
>>>> Sixth time is the charm, right? This time I'm certain that it
>>>> compiles with centos6, and contains the previously missing update
>>>> from Emilio to atomic_add-bench.
>>>
>>> For patches 03-16 (including the elusive patch 06 for which I reviewed
>>> 1bfe0cdf8
>>> from your atomic-4 branch on github):
>>>
>>> Reviewed-by: Emilio G. Cota <address@hidden>
>>>
>>> I just tested the patchset by running concurrencykit's ck_pr regression
>>> test (which
>>> tests lock'ed ops) for [guest-on-host bits, all x86] 64-on-64, 32-on-32 and
>>> 64-on-32. I ran it with TCG debugging enabled. It passes all tests.
^^^^^^^^^^^^^^^^^^^^^
>>
>> How odd, did you not see the double temp free for target-arm/translate.c?
>
> Free just sets a bit in a bitmap, so a double-free isn't visible without the
> --enable-debug-tcg assertion.
^^^^^^^^^^^^^^^^
That's why I was confused, I thought Emilio had it enabled.
--
Alex Bennée
- [Qemu-devel] [PATCH v6 29/35] target-arm: emulate SWP with atomic_xchg helper, (continued)
- [Qemu-devel] [PATCH v6 29/35] target-arm: emulate SWP with atomic_xchg helper, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 31/35] linux-user: remove handling of ARM's EXCP_STREX, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 32/35] linux-user: remove handling of aarch64's EXCP_STREX, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 30/35] target-arm: emulate aarch64's LL/SC using cmpxchg helpers, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 33/35] target-arm: remove EXCP_STREX + cpu_exclusive_{test, info}, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 34/35] target-alpha: Introduce MMU_PHYS_IDX, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 35/35] target-alpha: Emulate LL/SC using cmpxchg helpers, Richard Henderson, 2016/10/11
- Re: [Qemu-devel] [PATCH v6 00/35] cmpxchg-based emulation of atomics, Emilio G. Cota, 2016/10/16