[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/5] machine: Fix replacement of '_' by '-' in machin
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 1/5] machine: Fix replacement of '_' by '-' in machine property names |
Date: |
Mon, 17 Oct 2016 15:55:14 -0200 |
From: Markus Armbruster <address@hidden>
machine_set_property() replaces '_' by '-' in the property name.
Except it fails to replace an initial '_'. Screwed up in commit
b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property
'._-foo-bar' not found".
Error messages using a mangled name rather than the name the user
actually wrote is user-hostile, but that's a different topic.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
vl.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index c657acd..1c0b0ba 100644
--- a/vl.c
+++ b/vl.c
@@ -2804,17 +2804,16 @@ static int machine_set_property(void *opaque,
{
Object *obj = OBJECT(opaque);
Error *local_err = NULL;
- char *c, *qom_name;
+ char *p, *qom_name;
if (strcmp(name, "type") == 0) {
return 0;
}
qom_name = g_strdup(name);
- c = qom_name;
- while (*c++) {
- if (*c == '_') {
- *c = '-';
+ for (p = qom_name; *p; p++) {
+ if (*p == '_') {
+ *p = '-';
}
}
--
2.7.4
- [Qemu-devel] [PULL 0/5] machine + memory backend queue, 2016-10-17, Eduardo Habkost, 2016/10/17
- [Qemu-devel] [PULL 1/5] machine: Fix replacement of '_' by '-' in machine property names,
Eduardo Habkost <=
- [Qemu-devel] [PULL 2/5] machine: Register TYPE_MACHINE properties as class properties, Eduardo Habkost, 2016/10/17
- [Qemu-devel] [PULL 3/5] pc: Register TYPE_PC_MACHINE properties as class properties, Eduardo Habkost, 2016/10/17
- [Qemu-devel] [PULL 4/5] hostmem: Register TYPE_MEMORY_BACKEND properties as class properties, Eduardo Habkost, 2016/10/17
- [Qemu-devel] [PULL 5/5] hostmem-file: Register TYPE_MEMORY_BACKEND_FILE properties as class properties, Eduardo Habkost, 2016/10/17
- Re: [Qemu-devel] [PULL 0/5] machine + memory backend queue, 2016-10-17, Peter Maydell, 2016/10/18