Re: [Qemu-devel] [PATCH/RFC] vl: add no-panic option

[Christian Borntraeger]

On 10/17/2016 07:17 PM, Markus Armbruster wrote:
> Christian Borntraeger <address@hidden> writes:
> 
>> Some testcase will trigger a guest panic state. For testing purposes
>> it can be useful to exit QEMU anyway.
>>
>> Signed-off-by: Christian Borntraeger <address@hidden>
>> ---
>>  qemu-options.hx | 9 +++++++++
>>  vl.c            | 6 ++++++
>>  2 files changed, 15 insertions(+)
>>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index 01f01df..ee6d3d0 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -3301,6 +3301,15 @@ This allows for instance switching to monitor to 
>> commit changes to the
>>  disk image.
>>  ETEXI
>>  
>> +DEF("no-panic", 0, QEMU_OPTION_no_panic, \
>> +    "-no-panic       exit QEMU also in guest panic state\n", QEMU_ARCH_ALL)
>> +STEXI
>> address@hidden -no-panic
>> address@hidden -no-panic
>> +Exit QEMU on guest panic instead of keeping it alive. This allows for
>> +instance running tests that are known to panic at the end.
>> +ETEXI
>> +
>>  DEF("loadvm", HAS_ARG, QEMU_OPTION_loadvm, \
>>      "-loadvm [tag|id]\n" \
>>      "                start right away with a saved state (loadvm in 
>> monitor)\n",
> 
> Thank you for adding QEMU's 139-th option.  Are you sure it needs to be
> an option of its own, and can't be added to an existing QemuOpts option
> group?

Your welcome, let me know if I should come up with more :-)
Just kidding, that is why I added RFC to the patch.

Paolo suggested to default to exit on panic unless 
-no-shutdown is given and I want to go that path.