[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/18] block: only call aio_poll on the current
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 15/18] block: only call aio_poll on the current thread's AioContext |
Date: |
Tue, 18 Oct 2016 11:10:55 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Mon, Oct 17, 2016 at 10:04:59AM +0200, Paolo Bonzini wrote:
>
>
> On 16/10/2016 18:40, Stefan Hajnoczi wrote:
> > > void bdrv_wakeup(BlockDriverState *bs)
> > > {
> > > + if (bs->wakeup) {
> > > + aio_bh_schedule_oneshot(qemu_get_aio_context(), dummy_bh_cb,
> > > NULL);
> > > + }
> > > }
> >
> > Why use a dummy BH instead of aio_notify()?
>
> Originally I used aio_bh_schedule_oneshot() because aio_notify() is not
> enough for aio_poll() to return true. It's also true that I am not
> using anymore the result of aio_poll, though.
>
> Since this is not a fast path and it's not very much stressed by
> qemu-iotests, I think it's better if we can move towards making
> aio_notify() more or less an internal detail. If you prefer
> aio_notify(), however, I can look into that as well.
I was just wondering if there is a reason that I missed.
Stefan
signature.asc
Description: PGP signature