[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] qapi: fix memory leak in QmpOutputVisitor
From: |
Pino Toscano |
Subject: |
[Qemu-devel] [PATCH v2] qapi: fix memory leak in QmpOutputVisitor |
Date: |
Tue, 18 Oct 2016 12:37:32 +0200 |
qmp_output_start_struct() and qmp_output_start_list() create a new
QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
where it is saved as 'value'. When freeing the iterator in
qmp_output_free(), these values are never freed properly.
The simple solution is to qobject_decref() them.
Signed-off-by: Pino Toscano <address@hidden>
---
Changes in v2:
- added Signed-off-by
qapi/qmp-output-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/qmp-output-visitor.c b/qapi/qmp-output-visitor.c
index 9e3b67c..eedf256 100644
--- a/qapi/qmp-output-visitor.c
+++ b/qapi/qmp-output-visitor.c
@@ -220,6 +220,7 @@ static void qmp_output_free(Visitor *v)
while (!QSLIST_EMPTY(&qov->stack)) {
e = QSLIST_FIRST(&qov->stack);
QSLIST_REMOVE_HEAD(&qov->stack, node);
+ qobject_decref(e->value);
g_free(e);
}
--
2.7.4
- [Qemu-devel] [PATCH v2] qapi: fix memory leak in QmpOutputVisitor,
Pino Toscano <=