Re: [Qemu-devel] [Qemu-block] block/nfs: Fine grained runtime options in nfs

[Kevin Wolf]

Am 18.10.2016 um 14:46 hat Ashijeet Acharya geschrieben:
> On Tue, Oct 18, 2016 at 4:11 PM, Peter Lieven <address@hidden> wrote:
> > Am 17.10.2016 um 21:34 schrieb Ashijeet Acharya:
> >>
> >> On Tue, Oct 18, 2016 at 12:59 AM, Eric Blake <address@hidden> wrote:
> >>>
> >>> On 10/17/2016 01:00 PM, Ashijeet Acharya wrote:
> >>>
> >>>> One more relatively easy question though, will we include @port as an
> >>>> option in runtime_opts while converting NFS to use several
> >>>> runtime_opts? The reason I ask this because the uri syntax for NFS in
> >>>> QEMU looks like this:
> >>>>
> >>>>
> >>>> nfs://<host>/<export>/<filename>[?param=value[&param2=value2[&...]]]
> >>>
> >>> It's actually nfs://<host>[:port]/...
> >>>
> >>> so the URI syntax already supports port.
> >>
> >> But the commit message which added support for NFS had the uri which I
> >> mentioned above and the code for NFS does not make use of 'port'
> >> anywhere either, which is why I am a bit confused.
> >
> >
> > Hi Aschijeet,
> >
> > don't worry there is no port number when connecting to an NFS server.
> > The portmapper always listens on port 111. So theoretically we could
> > specifiy a port in the URL but it is ignored.
> 
> So that means I will be including 'port' in runtime_opts and then just
> ignoring any value that comes through it?

No, if there is nothing to configure there, leave it out. Adding an
option that doesn't do anything is not very useful.

Kevin