qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes
Date: Tue, 18 Oct 2016 11:58:19 -0200
User-agent: Mutt/1.7.0 (2016-08-17)

On Tue, Oct 18, 2016 at 12:07:30AM +0200, Andreas Färber wrote:
> Am 17.10.2016 um 23:02 schrieb Eduardo Habkost:
> > Ping?
> > 
> > Markus, do you want to merge this through your tree?
> > 
> > On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
> >> A few fixes on check-qom-proplist that will ensure we test both
> >> class properties and object properties, and catch errors when
> >> registering properties in test code.
> >>
> >> Eduardo Habkost (2):
> >>   tests: check-qom-proplist: Remove "bv" class property from class
> 
> This part I didn't quite understand from looking at the patch, but...

The "bv" property was being registered twice (as class property
and as instance property). The instance property registration was
always failing because of that.

One of them has to go away. I decided to remove the class
property because this allows the test code to cover both instance
properties ("bv") and class properties ("sv").

> 
> >>   tests: check-qom-proplist: Use &error_abort to catch errors
> 
> For this one:
> 
> Reviewed-by: Andreas Färber <address@hidden>

Thanks!

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]