Re: [Qemu-devel] [PATCH 04/13] virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass

[Cornelia Huck]

On Mon, 10 Oct 2016 13:53:32 +0200
Paolo Bonzini <address@hidden> wrote:

> Allow customization of the start and stop of ioeventfd.  This will
> allow direct start of dataplane without passing through the default
> ioeventfd handlers, which in turn allows using the dataplane logic
> instead of virtio_add_queue_aio.  It will also enable some code
> simplification, because the sole entry point to ioeventfd setup
> will be virtio_bus_set_host_notifier.
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/virtio/virtio-bus.c         | 55 +++++++++++-------------------------
>  hw/virtio/virtio.c             | 64 
> ++++++++++++++++++++++++++++++++++++++++++
>  include/hw/virtio/virtio-bus.h |  7 ++++-
>  include/hw/virtio/virtio.h     |  4 +++
>  4 files changed, 90 insertions(+), 40 deletions(-)
> 

> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 18ce333..3f6005a 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2120,15 +2120,79 @@ static Property virtio_properties[] = {
>      DEFINE_PROP_END_OF_LIST(),
>  };
> 
> +static int virtio_device_start_ioeventfd_impl(VirtIODevice *vdev)

The _impl postfix looks a bit awkward.
virtio_device_do_start_ioeventfd?
virtio_device_start_ioeventd_internal? (I don't really like these
either...)

Anyway,

Reviewed-by: Cornelia Huck <address@hidden>