[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/4] fdc: Add a floppy qbus
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/4] fdc: Add a floppy qbus |
Date: |
Thu, 20 Oct 2016 11:33:22 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 20.10.2016 um 10:06 hat KONRAD Frederic geschrieben:
> Hi,
>
> Le 20/10/2016 à 09:55, Kevin Wolf a écrit :
> >This adds a qbus to the floppy controller that should contain the floppy
> >drives eventually. At the moment it just exists and is empty.
> >
> >Signed-off-by: Kevin Wolf <address@hidden>
> >Reviewed-by: John Snow <address@hidden>
> >---
> > hw/block/fdc.c | 40 +++++++++++++++++++++++++++++++++++-----
> > 1 file changed, 35 insertions(+), 5 deletions(-)
> >
> >diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> >index b79873a..a3afb62 100644
> >--- a/hw/block/fdc.c
> >+++ b/hw/block/fdc.c
> >@@ -52,6 +52,33 @@
> > } \
> > } while (0)
> >
> >+
> >+/********************************************************/
> >+/* qdev floppy bus */
> >+
> >+#define TYPE_FLOPPY_BUS "Floppy"
>
> I don't remember of any TYPE_* starting with a uppercase. Maybe
> better using floppy? or floppy-bus?
This patch is mostly modelled after IDE. The block related ones are:
include/hw/ide/internal.h:#define TYPE_IDE_BUS "IDE"
include/hw/scsi/scsi.h:#define TYPE_SCSI_BUS "SCSI"
There are more uppercase ones (even non-acronyms), but I admit that I
didn't check for other users but just did what IDE does.
Kevin
- [Qemu-devel] [PATCH v4 0/4] fdc: Use separate qdev device for drives, Kevin Wolf, 2016/10/20
- [Qemu-devel] [PATCH v4 1/4] fdc: Add a floppy qbus, Kevin Wolf, 2016/10/20
- [Qemu-devel] [PATCH v4 2/4] fdc: Add a floppy drive qdev, Kevin Wolf, 2016/10/20
- [Qemu-devel] [PATCH v4 3/4] fdc: Move qdev properties to FloppyDrive, Kevin Wolf, 2016/10/20
- [Qemu-devel] [PATCH v4 4/4] qemu-iotests: Test creating floppy drives, Kevin Wolf, 2016/10/20
- Re: [Qemu-devel] [PATCH v4 0/4] fdc: Use separate qdev device for drives, John Snow, 2016/10/20