Re: [Qemu-devel] [RFC 00/13] Multifd v2

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC 00/13] Multifd v2

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ee17fab migration: flush receive queue
27a9800 migration: [HACK]Transfer pages over new channels
25f1b86 migration: Test new fd infrastructure
d48dd5e migration: Create thread infrastructure for multifd recv side
e7a5acd migration: Send the fd number which we are going to use for this page
b2ace91 migration: Create thread infrastructure for multifd send side
bdfb79f migration: create ram_multifd_page
8209364 migration: Start of multiple fd work
eeb3b70 migration: create multifd migration threads
a6d8287 migration: Create x-multifd-threads parameter
8cc47c1 migration: Add multifd capability
287498c migration: [HACK] Don't create decompression threads if not enabled
4dc8431 migration: create Migration Incoming State at init time

=== OUTPUT BEGIN ===
Checking PATCH 1/13: migration: create Migration Incoming State at init time...
Checking PATCH 2/13: migration: [HACK] Don't create decompression threads if 
not enabled...
Checking PATCH 3/13: migration: Add multifd capability...
Checking PATCH 4/13: migration: Create x-multifd-threads parameter...
WARNING: line over 80 characters
#92: FILE: migration/migration.c:822:
+            (params->x_multifd_threads < 1 || params->x_multifd_threads > 
255)) {

total: 0 errors, 1 warnings, 128 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/13: migration: create multifd migration threads...
ERROR: space required before the open brace '{'
#103: FILE: migration/ram.c:409:
+    while (!params->quit){

ERROR: space required before the open brace '{'
#128: FILE: migration/ram.c:434:
+    if (!migrate_multifd()){

ERROR: space required before the open brace '{'
#146: FILE: migration/ram.c:452:
+    if (!migrate_multifd()){

ERROR: trailing whitespace
#174: FILE: migration/ram.c:480:
+ $

ERROR: space required before the open brace '{'
#176: FILE: migration/ram.c:482:
+    while (!params->quit){

ERROR: space required before the open brace '{'
#201: FILE: migration/ram.c:507:
+    if (!migrate_multifd()){

ERROR: space required before the open brace '{'
#219: FILE: migration/ram.c:525:
+    if (!migrate_multifd()){

total: 7 errors, 0 warnings, 206 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/13: migration: Start of multiple fd work...
ERROR: space required before the open parenthesis '('
#80: FILE: migration/ram.c:473:
+        if(!multifd_send[i].c) {

ERROR: space required before the open parenthesis '('
#135: FILE: migration/ram.c:568:
+        if(!multifd_recv[i].c) {

ERROR: do not use C99 // comments
#181: FILE: migration/socket.c:50:
+    // Remove channel here

ERROR: do not use C99 // comments
#197: FILE: migration/socket.c:66:
+    // Remove channel here

ERROR: do not use C99 // comments
#231: FILE: migration/socket.c:205:
+//    qio_channel_close(ioc, NULL);

total: 5 errors, 0 warnings, 201 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/13: migration: create ram_multifd_page...
Checking PATCH 8/13: migration: Create thread infrastructure for multifd send 
side...
Checking PATCH 9/13: migration: Send the fd number which we are going to use 
for this page...
Checking PATCH 10/13: migration: Create thread infrastructure for multifd recv 
side...
Checking PATCH 11/13: migration: Test new fd infrastructure...
ERROR: "(foo*)" should be "(foo *)"
#34: FILE: migration/ram.c:442:
+                != sizeof(uint8_t*)) {

ERROR: "(foo*)" should be "(foo *)"
#59: FILE: migration/ram.c:595:
+                                 sizeof(uint8_t*), &error_abort)

total: 2 errors, 0 warnings, 64 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/13: migration: [HACK]Transfer pages over new channels...
ERROR: space required before the open parenthesis '('
#91: FILE: migration/ram.c:565:
+        while(!multifd_send[i].done) {

total: 1 errors, 0 warnings, 134 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/13: migration: flush receive queue...
ERROR: do not initialise globals to 0 or NULL
#49: FILE: migration/ram.c:405:
+bool multifd_needs_flush = false;

ERROR: space required before the open parenthesis '('
#69: FILE: migration/ram.c:733:
+        while(!multifd_recv[i].done) {

total: 2 errors, 0 warnings, 89 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden