Re: [Qemu-devel] [PATCH 07/38] xilinx: fix buffer overflow on realize

[Paolo Bonzini]

On 22/10/2016 11:52, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/ssi/xilinx_spips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index e2b77dc..ab7fa6f 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -620,7 +620,7 @@ static void xilinx_spips_realize(DeviceState *dev, Error 
> **errp)
>  
>      s->cs_lines = g_new0(qemu_irq, s->num_cs * s->num_busses);
>      ssi_auto_connect_slaves(DEVICE(s), s->cs_lines, s->spi[0]);
> -    ssi_auto_connect_slaves(DEVICE(s), s->cs_lines, s->spi[1]);

Better add a for loop going up to s->num_busses.  I can do that on commit.

Paolo

>      sysbus_init_irq(sbd, &s->irq);
>      for (i = 0; i < s->num_cs * s->num_busses; ++i) {
>          sysbus_init_irq(sbd, &s->cs_lines[i]);
>