[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors |
Date: |
Mon, 24 Oct 2016 15:07:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 24/10/2016 14:59, Markus Armbruster wrote:
> "Dr. David Alan Gilbert (git)" <address@hidden> writes:
>
>> From: "Dr. David Alan Gilbert" <address@hidden>
>>
>> In a1771070e7 I added an error message during migration loading
>> so you could see the field that failed to load.
>> Unfortunately this triggers during the expected-failure case
>> testing in tests/test-vmstate.
>>
>> This silences that error by providing a dummy monitor pointer
>> that doesn't output anything and then selecting it around
>> the noisy part of the test.
>>
>> (I couldn't find anywhere better than libqtest.h for the declaration
>> but stubs doesn't have it's own header; is it worth creating one
>> just for that?)
>
> Maybe. Always hard to say for the first one.
>
> You could simply put it in monitor.h. When somebody uses it outside
> tests, linking fails. If that bothers you, feel free to implement a
> silent non-stub monitor.
>
> With Eric's spelling fixes squashed in, and with or without my
> suggestion on PATCH 2:
> Reviewed-by: Markus Armbruster <address@hidden>
We could also implement error_vprintf so that it calls g_test_message().
That would improve the logging.
Paolo