[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 46/50] char: remove unused qemu_chr_fe_event
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 46/50] char: remove unused qemu_chr_fe_event |
Date: |
Mon, 24 Oct 2016 15:47:31 +0200 |
From: Marc-André Lureau <address@hidden>
I introduced this function in d61b0c9a2f7f, but it isn't
used. Furthermore, it was incomplete, as it would need to translate QEMU
chr events to Spice port events.
(presumably it was used in the follow-up NBD-spice series that was not
completed: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02024.html)
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
include/sysemu/char.h | 11 -----------
qemu-char.c | 9 ---------
spice-qemu-char.c | 10 ----------
3 files changed, 30 deletions(-)
diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index de0d99b..6bad856 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -103,7 +103,6 @@ struct CharDriverState {
void (*chr_accept_input)(struct CharDriverState *chr);
void (*chr_set_echo)(struct CharDriverState *chr, bool echo);
void (*chr_set_fe_open)(struct CharDriverState *chr, int fe_open);
- void (*chr_fe_event)(struct CharDriverState *chr, int event);
CharBackend *be;
void *opaque;
char *label;
@@ -239,16 +238,6 @@ void qemu_chr_fe_set_echo(CharBackend *be, bool echo);
void qemu_chr_fe_set_open(CharBackend *be, int fe_open);
/**
- * @qemu_chr_fe_event:
- *
- * Send an event from the front end to the back end. It does nothing
- * without associated CharDriver.
- *
- * @event the event to send
- */
-void qemu_chr_fe_event(CharBackend *be, int event);
-
-/**
* @qemu_chr_fe_printf:
*
* Write to a character backend using a printf style interface. This
diff --git a/qemu-char.c b/qemu-char.c
index 3b98acf..9bd2e65 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -4226,15 +4226,6 @@ void qemu_chr_fe_set_open(CharBackend *be, int fe_open)
}
}
-void qemu_chr_fe_event(CharBackend *be, int event)
-{
- CharDriverState *chr = be->chr;
-
- if (chr && chr->chr_fe_event) {
- chr->chr_fe_event(chr, event);
- }
-}
-
guint qemu_chr_fe_add_watch(CharBackend *be, GIOCondition cond,
GIOFunc func, void *user_data)
{
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 930b8c5..89fae6d 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -236,15 +236,6 @@ static void spice_port_set_fe_open(struct CharDriverState
*chr, int fe_open)
#endif
}
-static void spice_chr_fe_event(struct CharDriverState *chr, int event)
-{
-#if SPICE_SERVER_VERSION >= 0x000c02
- SpiceCharDriver *s = chr->opaque;
-
- spice_server_port_event(&s->sin, event);
-#endif
-}
-
static void print_allowed_subtypes(void)
{
const char** psubtype;
@@ -292,7 +283,6 @@ static CharDriverState *chr_open(const char *subtype,
chr->chr_free = spice_chr_free;
chr->chr_set_fe_open = set_fe_open;
chr->explicit_be_open = true;
- chr->chr_fe_event = spice_chr_fe_event;
chr->chr_accept_input = spice_chr_accept_input;
QLIST_INSERT_HEAD(&spice_chars, s, next);
--
1.8.3.1
- [Qemu-devel] [PULL 36/50] vhost-user: only initialize queue 0 CharBackend, (continued)
- [Qemu-devel] [PULL 36/50] vhost-user: only initialize queue 0 CharBackend, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 30/50] char: replace PROP_CHR with CharBackend, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 31/50] char: remaining switch to CharBackend in frontend, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 37/50] char: replace qemu_chr_claim/release with qemu_chr_fe_init/deinit, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 41/50] char: rename chr_close/chr_free, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 43/50] char: move fe_open in CharBackend, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 39/50] tests: start chardev unit tests, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 45/50] char: use an enum for CHR_EVENT, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 38/50] char: make some qemu_chr_fe skip if no driver, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 40/50] char: move front end handlers in CharBackend, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 46/50] char: remove unused qemu_chr_fe_event,
Paolo Bonzini <=
- [Qemu-devel] [PULL 42/50] char: remove explicit_fe_open, use a set_handlers argument, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 34/50] char: use qemu_chr_fe* functions with CharBackend argument, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 44/50] char: remove unused CHR_EVENT_FOCUS, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 47/50] char: replace avail_connections, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 48/50] char: use common error path in qmp_chardev_add, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 49/50] char: remove explicit_be_open from CharDriverState, Paolo Bonzini, 2016/10/24
- [Qemu-devel] [PULL 50/50] exec.c: workaround regression caused by alignment change in d2f39ad, Paolo Bonzini, 2016/10/24
- Re: [Qemu-devel] [PULL 00/50] Miscellaneous patches for 2016-10-24, Peter Maydell, 2016/10/24