[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] less confusing block file names
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] less confusing block file names |
Date: |
Mon, 24 Oct 2016 17:14:00 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 24.10.2016 um 16:44 hat Paolo Bonzini geschrieben:
> On 24/10/2016 15:47, Kevin Wolf wrote:
> > One effect that makes me less than fully happy is that 'git log
> > block/raw.c' without --follow mixes the history of the renamed driver
> > with the history of the old, differently licensed one. On the other
> > hand, the removal of the old driver happened three years ago, so it's
> > probably unlikely that people confuse what belongs to which one and
> > revive old code accidentally.
>
> Hmm, this makes it sensible to only apply patch 2, especially since Eric
> has corteously split them. :)
Maybe rename to something like raw-format.c instead then in patch 1?
I must admit that it's reasonable enough to make the assumption that
raw_bsd.c has something to do with a BSD-specific block driver.
Kevin
- [Qemu-devel] [PATCH 0/2] less confusing block file names, Eric Blake, 2016/10/19
- [Qemu-devel] [PATCH 1/2] block: Rename raw_bsd to raw.c, Eric Blake, 2016/10/19
- [Qemu-devel] [PATCH 2/2] block: rename raw-{posix, win32} to file-*.c, Eric Blake, 2016/10/19
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] less confusing block file names, John Snow, 2016/10/21
- Re: [Qemu-devel] [PATCH 0/2] less confusing block file names, Kevin Wolf, 2016/10/24
- Re: [Qemu-devel] [PATCH 0/2] less confusing block file names, Eric Blake, 2016/10/24