[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] memory: Don't use memcpy for ram marked as
|
From: |
Alex Williamson |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH] memory: Don't use memcpy for ram marked as skip_dump |
|
Date: |
Mon, 24 Oct 2016 09:16:47 -0600 |
On Mon, 24 Oct 2016 13:05:56 +0200
Paolo Bonzini <address@hidden> wrote:
> On 22/10/2016 17:09, Alex Williamson wrote:
> > > Add a trace message for each mrop.
> >
> > Yes, this is on my todo list post-RFC.
>
> Another thing to think about:
>
> 1) rename all the skip_dump occurrences in the API to device_memory.
> The new ops make it much more specific than just skipping the region
> during dumps.
>
> 2) get rid of mr->skip_dump and check mr->ops == &skip_dump_ops (or
> device_memory_ops) instead.
Yep, I like those ideas. Thanks,
Alex