[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 31/37] target-arm: emulate SWP with atomic_xchg h
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v8 31/37] target-arm: emulate SWP with atomic_xchg helper |
Date: |
Mon, 24 Oct 2016 10:39:42 -0700 |
From: "Emilio G. Cota" <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-arm/translate.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index a9bb986..722f7b3 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -8757,25 +8757,27 @@ static void disas_arm_insn(DisasContext *s, unsigned
int insn)
}
tcg_temp_free_i32(addr);
} else {
+ TCGv taddr;
+ TCGMemOp opc = s->be_data;
+
/* SWP instruction */
rm = (insn) & 0xf;
- /* ??? This is not really atomic. However we know
- we never have multiple CPUs running in parallel,
- so it is good enough. */
- addr = load_reg(s, rn);
- tmp = load_reg(s, rm);
- tmp2 = tcg_temp_new_i32();
if (insn & (1 << 22)) {
- gen_aa32_ld8u(s, tmp2, addr, get_mem_index(s));
- gen_aa32_st8(s, tmp, addr, get_mem_index(s));
+ opc |= MO_UB;
} else {
- gen_aa32_ld32u(s, tmp2, addr, get_mem_index(s));
- gen_aa32_st32(s, tmp, addr, get_mem_index(s));
+ opc |= MO_UL | MO_ALIGN;
}
- tcg_temp_free_i32(tmp);
+
+ addr = load_reg(s, rn);
+ taddr = gen_aa32_addr(s, addr, opc);
tcg_temp_free_i32(addr);
- store_reg(s, rd, tmp2);
+
+ tmp = load_reg(s, rm);
+ tcg_gen_atomic_xchg_i32(tmp, taddr, tmp,
+ get_mem_index(s), opc);
+ tcg_temp_free(taddr);
+ store_reg(s, rd, tmp);
}
}
} else {
--
2.7.4
- [Qemu-devel] [PATCH v8 12/37] cputlb: Remove includes from softmmu_template.h, (continued)
- [Qemu-devel] [PATCH v8 12/37] cputlb: Remove includes from softmmu_template.h, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 17/37] tcg: Add CONFIG_ATOMIC64, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 15/37] tcg: Add atomic helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 24/37] target-i386: emulate LOCK'ed XADD using atomic helper, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 21/37] target-i386: emulate LOCK'ed INC using atomic helper, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 22/37] target-i386: emulate LOCK'ed NOT using atomic helper, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 23/37] target-i386: emulate LOCK'ed NEG using cmpxchg helper, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 25/37] target-i386: emulate LOCK'ed BTX ops using atomic helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 26/37] target-i386: emulate XCHG using atomic helper, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 28/37] tests: add atomic_add-bench, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 31/37] target-arm: emulate SWP with atomic_xchg helper,
Richard Henderson <=
- [Qemu-devel] [PATCH v8 30/37] target-arm: emulate LL/SC using cmpxchg helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 35/37] target-arm: remove EXCP_STREX + cpu_exclusive_{test, info}, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 29/37] target-arm: Rearrange aa32 load and store functions, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 27/37] target-i386: remove helper_lock(), Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 33/37] linux-user: remove handling of ARM's EXCP_STREX, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 34/37] linux-user: remove handling of aarch64's EXCP_STREX, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 32/37] target-arm: emulate aarch64's LL/SC using cmpxchg helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 37/37] target-alpha: Emulate LL/SC using cmpxchg helpers, Richard Henderson, 2016/10/24
- [Qemu-devel] [PATCH v8 36/37] target-alpha: Introduce MMU_PHYS_IDX, Richard Henderson, 2016/10/24
- Re: [Qemu-devel] [PATCH v8 00/37] cmpxchg atomic operations, Emilio G. Cota, 2016/10/24