[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device options |
|
Date: |
Tue, 25 Oct 2016 13:58:15 +0800 |
|
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Sat, 10/22 02:11, Max Reitz wrote:
> On 30.09.2016 14:09, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > hw/core/qdev-properties.c | 10 ++++++++++
> > include/hw/block/block.h | 1 +
> > include/hw/qdev-properties.h | 3 +++
> > 3 files changed, 14 insertions(+)
>
> Why don't you add _conf.lock_mode in this very patch (instead of patch
> 3) and pull it in front of patch 12? Setting the mode won't do anything
> until it's implemented for the various block devices, but I don't think
> that's a bad thing.
Sounds good!
Fam