Re: [Qemu-devel] [PATCH v14 05/21] qapi: rename QmpOutputVisitor to QObjectOutputVisitor

[Markus Armbruster]

"Daniel P. Berrange" <address@hidden> writes:

> The QmpOutputVisitor has no direct dependency on QMP. It is
> valid to use it anywhere that one wants a QObject. Rename it
> to better reflect its functionality as a generic QAPI
> to QObject converter.
>
> Reviewed-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  block/qapi.c                                       |   4 +-
>  blockdev.c                                         |   4 +-
>  docs/qapi-code-gen.txt                             |   2 +-
>  ...p-output-visitor.h => qobject-output-visitor.h} |  10 +-
>  qapi/Makefile.objs                                 |   2 +-
>  qapi/qapi-clone-visitor.c                          |   2 +-
>  qapi/qmp-output-visitor.c                          | 256 
> ---------------------
>  qapi/qobject-output-visitor.c                      | 254 ++++++++++++++++++++
>  qemu-img.c                                         |   8 +-
>  qom/object_interfaces.c                            |   2 +-
>  qom/qom-qobject.c                                  |   4 +-
>  scripts/qapi-commands.py                           |   4 +-
>  scripts/qapi-event.py                              |   4 +-
>  tests/.gitignore                                   |   2 +-
>  tests/Makefile.include                             |   8 +-
>  tests/check-qnull.c                                |   4 +-
>  ...put-visitor.c => test-outqobject-output-visitor.c} |   6 +-
>  tests/test-string-output-visitor.c                 |   2 +-
>  tests/test-visitor-serialization.c                 |   4 +-
>  util/qemu-sockets.c                                |   2 +-
>  20 files changed, 291 insertions(+), 293 deletions(-)
>  rename include/qapi/{qmp-output-visitor.h => qobject-output-visitor.h} (66%)
>  delete mode 100644 qapi/qmp-output-visitor.c
>  create mode 100644 qapi/qobject-output-visitor.c
>  rename tests/{test-qmp-output-visitor.c => test-qobject-output-visitor.c} 
> (99%)

Renaming the file and the identifiers at the same time defeats rename
detection, and thus git-log --follow.  Since this would be quite
annoying, I'm going to split this patch into one that renames files and
one that renames C identifiers.