[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearrang
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged |
|
Date: |
Tue, 25 Oct 2016 11:08:27 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/25/2016 09:35 AM, Markus Armbruster wrote:
> This is how I propose to rearrange PATCH 04+05 of Dan's "[PATCH v14
> 00/21] QAPI/QOM work for non-scalar object properties" (really v15) in
> my pull request, to make git's rename detection work. The result is
> identical except for two comments I touched up:
>
Looks sane to me. Also, looks like my R-b is already present by virtue
of the pre-split review I gave.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature