qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 18/23] target-m68k: Remove incorrect clearing of cc_x


From: Laurent Vivier
Subject: [Qemu-devel] [PULL 18/23] target-m68k: Remove incorrect clearing of cc_x
Date: Tue, 25 Oct 2016 21:03:14 +0200

From: Richard Henderson <address@hidden>

The CF docs certainly doesnt suggest this is true.

Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
 target-m68k/helper.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/target-m68k/helper.c b/target-m68k/helper.c
index 1a54e66..a9974b1 100644
--- a/target-m68k/helper.c
+++ b/target-m68k/helper.c
@@ -207,19 +207,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, 
int op)
         break;
     case CC_OP_LOGICB:
         SET_NZ(dest, int8_t);
-        goto set_x;
         break;
     case CC_OP_LOGICW:
         SET_NZ(dest, int16_t);
-        goto set_x;
         break;
     case CC_OP_LOGIC:
         SET_NZ(dest, int32_t);
-set_x:
-        if (!m68k_feature(env, M68K_FEATURE_M68000)) {
-            /* Unlike m68k, coldfire always clears the overflow bit.  */
-            env->cc_x = 0;
-        }
         break;
     case CC_OP_ADDB:
         SET_FLAGS_ADD(int8_t, uint8_t);
-- 
2.7.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]