[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/23] target-m68k: Remove incorrect clearing of cc_x
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL 18/23] target-m68k: Remove incorrect clearing of cc_x |
Date: |
Tue, 25 Oct 2016 21:03:14 +0200 |
From: Richard Henderson <address@hidden>
The CF docs certainly doesnt suggest this is true.
Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
target-m68k/helper.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/target-m68k/helper.c b/target-m68k/helper.c
index 1a54e66..a9974b1 100644
--- a/target-m68k/helper.c
+++ b/target-m68k/helper.c
@@ -207,19 +207,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env,
int op)
break;
case CC_OP_LOGICB:
SET_NZ(dest, int8_t);
- goto set_x;
break;
case CC_OP_LOGICW:
SET_NZ(dest, int16_t);
- goto set_x;
break;
case CC_OP_LOGIC:
SET_NZ(dest, int32_t);
-set_x:
- if (!m68k_feature(env, M68K_FEATURE_M68000)) {
- /* Unlike m68k, coldfire always clears the overflow bit. */
- env->cc_x = 0;
- }
break;
case CC_OP_ADDB:
SET_FLAGS_ADD(int8_t, uint8_t);
--
2.7.4
- [Qemu-devel] [PULL 21/23] target-m68k: Use setcond for scc, (continued)
- [Qemu-devel] [PULL 21/23] target-m68k: Use setcond for scc, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 08/23] target-m68k: set PAGE_BITS to 12 for m68k, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 07/23] target-m68k: define operand sizes, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 12/23] target-m68k: remove m68k_cpu_exec_enter() and m68k_cpu_exec_exit(), Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 05/23] target-m68k: introduce read_imXX() functions, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 11/23] target-m68k: Replace helper_xflag_lt with setcond, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 10/23] target-m68k: allow to update flags with operation on words and bytes, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 23/23] target-m68k: Optimize gen_flush_flags, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 20/23] target-m68k: Introduce DisasCompare, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 16/23] target-m68k: Print flags properly, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 18/23] target-m68k: Remove incorrect clearing of cc_x,
Laurent Vivier <=
- [Qemu-devel] [PULL 17/23] target-m68k: Some fixes to SR and flags management, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 14/23] target-m68k: don't update cc_dest in helpers, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 22/23] target-m68k: Optimize some comparisons, Laurent Vivier, 2016/10/25
- [Qemu-devel] [PULL 19/23] target-m68k: Reorg flags handling, Laurent Vivier, 2016/10/25
- Re: [Qemu-devel] [PULL 00/23] M68k part1 patches, Peter Maydell, 2016/10/27