Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend

[Gerd Hoffmann]

> > Also splitting this up would be nice.
> 
> You mean separating the move of the sdl1.2 code from the addition of
> sdl2+gtk code? (and perhaps separate sdl2 and gtk?)

One patch adding new console.[ch] interfaces, then one patch per UI,
finally switch over baum to the new interfaces.

Maybe put sdl-ui + baum into one patch as this moves existing code sdl
code from baum.c to sdl*.c for the most part.

> > No loop needed here.  qemu sorts consoles so the graphic ones come
> > first.
> 
> Ok, but are we sure nobody will change that assumption someday?  Or do
> we assume that if somebody changes it he will notice the assumption in
> qemu_graphic_console_get_window_id?

If that assumption ever changes the code here (and in quite a few more
places) must be adapted to it.

cheers,
  Gerd