Re: [Qemu-devel] [PATCH v2 02/11] qapi: fix schema symbol sections

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> According to documentation, there needs to be '##' to start a symbol

Suggest to be explicit, and say "According to docs/qapi-code-gen.txt".

> section, that's also what the documentation parser expects.

Does the doc parser complain when its expectation isn't met?  I haven't
reviewed it, yet...

In my opinion, qapi-code-gen.txt should demand everything the doc parser
needs (it may demand more), and the doc parser should complain about
everything qapi-code-gen.txt demands and the schema doesn't provide.

> Signed-off-by: Marc-André Lureau <address@hidden>

The patch fixes all missing '##' at the beginning of definition comment
blocks.  Good.

qapi-code-gen.txt also demands '##' at the end.  Does the parser rely on
it?  Offenders:

diff --git a/qapi-schema.json b/qapi-schema.json
index fc732cb..0cc9ee6 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -780,6 +780,7 @@
 # command.
 #
 # Since: 2.5
+##
 { 'command': 'migrate-start-postcopy' }
 
 ##
@@ -4429,7 +4430,7 @@
 #
 # @DIMM: memory slot
 # @CPU: logical CPU slot (since 2.7)
-#
+##
 { 'enum': 'ACPISlotType', 'data': [ 'DIMM', 'CPU' ] }
 
 ##