qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/11] qapi: fix @ACPI sections


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 04/11] qapi: fix @ACPI sections
Date: Wed, 26 Oct 2016 15:38:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Marc-André Lureau <address@hidden> writes:

> This helps the doc parser.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  qapi-schema.json | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 3091993..3ac8637 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4414,14 +4414,16 @@
>  ##
>  { 'command': 'query-memory-devices', 'returns': ['MemoryDeviceInfo'] }
>  
> -## @ACPISlotType
> +##
> +# @ACPISlotType
>  #
>  # @DIMM: memory slot
>  # @CPU: logical CPU slot (since 2.7)
>  #
>  { 'enum': 'ACPISlotType', 'data': [ 'DIMM', 'CPU' ] }
>  
> -## @ACPIOSTInfo
> +##
> +# @ACPIOSTInfo
>  #
>  # OSPM Status Indication for a device
>  # For description of possible values of @source and @status fields

Could be squashed into PATCH 02.

Another, unrelated thing to clean up while you're at it: { 'include':
'qapi/rocker.json' } is in the middle of qapi-schema.json for no obvious
reason.  Let's move it next to the other includes, in a separate patch.

There's also inconsistent whitespace use, but I think that's best left
for another day.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]