Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 04/17] migration: Switch to COLO process after finishing loadvm

[Hailiang Zhang]

On 2016/10/26 13:01, Amit Shah wrote:
> On (Tue) 18 Oct 2016 [20:10:00], zhanghailiang wrote:
> > Switch from normal migration loadvm process into COLO checkpoint process if
> > COLO mode is enabled.
> >
> > We add three new members to struct MigrationIncomingState,
> > 'have_colo_incoming_thread' and 'colo_incoming_thread' record the COLO
> > related thread for secondary VM, 'migration_incoming_co' records the
> > original migration incoming coroutine.
> >
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Li Zhijian <address@hidden>
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> (snip)
>
> > +void migration_incoming_exit_colo(void)
> > +{
> > +    colo_info.colo_requested = 0;
>
> Please use 'true' and 'false' for bools.

Good catch, fix in next version.

Thanks,
hailiang

> Otherwise,
>
> Reviewed-by: Amit Shah <address@hidden>
>
>
>
>                 Amit
>
> .