[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/13] qapi: Allow blockdev-add for NBD
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/13] qapi: Allow blockdev-add for NBD |
Date: |
Wed, 26 Oct 2016 16:17:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 26.10.2016 01:57, Eric Blake wrote:
> On 10/25/2016 08:11 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> qapi/block-core.json | 25 ++++++++++++++++++++++---
>> 1 file changed, 22 insertions(+), 3 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index 97b1205..4b4a74c 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -1703,14 +1703,15 @@
>> #
>> # @host_device, @host_cdrom: Since 2.1
>> # @gluster: Since 2.7
>> +# @nbd: Since 2.8
>
> 'replication' was also added in 2.8; we should mention it while touching
> this.
>
>> #
>> # Since: 2.0
>> ##
>> { 'enum': 'BlockdevDriver',
>> 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
>> 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
>> - 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
>> - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
>> + 'host_device', 'http', 'https', 'luks', 'nbd', 'null-aio',
>> + 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
>> 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
>
> Can we fix the TAB damage while at it?
>
> Reviewed-by: Eric Blake <address@hidden>
You're completely right with both comments, but I think putting them in
separate patches might be better (we even have time after soft freeze
for this). If the maintainer applying this patch decides to put the tab
fix into this patch while applying, I wouldn't mind, though.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 00/13] qapi: Allow blockdev-add for NBD, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 01/13] block/nbd: Drop trailing "." in error messages, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 02/13] block/nbd: Reject port parameter without host, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 04/13] block/nbd: Use qdict_put(), Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 05/13] block/nbd: Add nbd_has_filename_options_conflict(), Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 08/13] qapi: Allow blockdev-add for NBD, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 03/13] block/nbd: Default port in nbd_refresh_filename(), Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 07/13] block/nbd: Use SocketAddress options, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 11/13] socket_scm_helper: Accept fd directly, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 09/13] iotests.py: Add qemu_nbd function, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 06/13] block/nbd: Accept SocketAddress, Max Reitz, 2016/10/25
- [Qemu-devel] [PATCH v5 12/13] iotests: Add assert_json_filename_equal() method, Max Reitz, 2016/10/25