|
From: | Hailiang Zhang |
Subject: | Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover |
Date: | Wed, 26 Oct 2016 23:32:08 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 2016/10/26 21:59, Dr. David Alan Gilbert wrote:
* Amit Shah (address@hidden) wrote:On (Tue) 18 Oct 2016 [20:10:08], zhanghailiang wrote:We leave users to choose whatever heartbeat solution they want, if the heartbeat is lost, or other errors they detect, they can use experimental command 'x_colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations accordingly. For example, if the command is sent to the PVM, the Primary side will exit COLO mode and take over operation.Primary should already be in control, so there's nothing special needed to 'take over operation'? At max, it should not do periodic syncs anymore till it hears from a (new) secondary.But it has to stop waiting for an ack from the secondary, and stop sending copies of block data to it etc.
Yes, you are right, we still need to do this cleanup work :) Thanks, hailiang
DaveIf sent to the Secondary, the secondary will run failover work, then take over server operation to become the new Primary. Cc: Luiz Capitulino <address@hidden> Cc: Eric Blake <address@hidden> Cc: Markus Armbruster <address@hidden> Signed-off-by: zhanghailiang <address@hidden> Signed-off-by: Li Zhijian <address@hidden> Reviewed-by: Dr. David Alan Gilbert <address@hidden>Reviewed-by: Amit Shah <address@hidden> Amit-- Dr. David Alan Gilbert / address@hidden / Manchester, UK .
[Prev in Thread] | Current Thread | [Next in Thread] |