[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_p
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code |
Date: |
Wed, 26 Oct 2016 18:57:12 +0100 |
On 26 October 2016 at 17:57, Eduardo Habkost <address@hidden> wrote:
> On Wed, Oct 26, 2016 at 05:48:03PM +0100, Peter Maydell wrote:
>> On 26 October 2016 at 17:30, Eduardo Habkost <address@hidden> wrote:
>> > The only remaining user of object_class_property_add() is
>> > arm_cpu_post_init(), but removing it may take some work. While we
>> > don't change it, warn people to not use the function in new code.
>>
>> This is about the third time I've seen this commit
>> message go past, but:
>>
>> git grep object_class_property_add target-arm => no hits
>
> Erm. I meant qdev_property_add_static(). Sorry.
> Commit message needs to be rewritten as:
>
> qdev: Warning about using qdev_property_add_static() in new code
>
> The only remaining user of qdev_property_add_static() is
> arm_cpu_post_init(), but removing it may take some work. While we
> don't change it, warn people to not use the function in new code.
Can we say what the recommended replacement function is?
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v3 6/8] qom: object_class_property_iter_init() function, (continued)
[Qemu-devel] [PATCH v3 7/8] qmp: Support abstract classes on device-list-properties, Eduardo Habkost, 2016/10/26
[Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code, Eduardo Habkost, 2016/10/26
[Qemu-devel] [PATCH v3 3/8] qdev: device_class_set_props() function, Eduardo Habkost, 2016/10/26
Re: [Qemu-devel] [PATCH v3 0/8] qdev class properties + abstract class support on device-list-properties, Eduardo Habkost, 2016/10/27