qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 0/3] qmp output visitor test improvement


From: Eric Blake
Subject: [Qemu-devel] [PATCH v2 0/3] qmp output visitor test improvement
Date: Wed, 26 Oct 2016 16:12:35 -0500

Well, technically qobject output visitor, but keeping the
cover letter subject unchanged helps for continuity

Given the threads last week with Pino's claim that we had a
memory leak, and Markus' counter-claim that the proposed
patch was reverting an earlier double-free fix, I ended up
enhancing the testsuite to prove under valgrind whether we
indeed have a problem.  The good news is that the existing
visitor code is correct, but having more tests will help
prevent future regression attempts :)

v1 was here:
https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg05699.html

since then:
patch 2 is new
patch 3 (former 2/2) is rebased (now that it is qobject rather
than qmp visitor) and enhanced (list and alternates, in addition
to objects)

Eric Blake (3):
  tests: Simplify expected error checking for qmp output
  qapi: Further enhance visitor virtual walk doc example
  tests: Enhance qobject output to cover partial visit

 include/qapi/visitor.h              | 41 +++++++++++++++++++----------
 tests/test-qobject-output-visitor.c | 51 +++++++++++++++++++++++++++++++------
 2 files changed, 71 insertions(+), 21 deletions(-)

-- 
2.7.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]