[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads param
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads parameter |
Date: |
Wed, 26 Oct 2016 16:16:08 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/21/2016 02:42 PM, Juan Quintela wrote:
> Indicates the number of threads that we would create. By default we
> create 2 threads.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> @@ -1386,6 +1389,9 @@ void hmp_migrate_set_parameter(Monitor *mon, const
> QDict *qdict)
> p.has_downtime_limit = true;
> use_int_value = true;
> break;
> + case MIGRATION_PARAMETER_X_MULTIFD_THREADS:
> + p.has_x_multifd_threads = true;
> + break;
Won't work unless you add a line 'use_int_value = true;'
> }
>
> if (use_int_value) {
> @@ -1402,6 +1408,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const
> QDict *qdict)
> p.cpu_throttle_initial = valueint;
> p.cpu_throttle_increment = valueint;
> p.downtime_limit = valueint;
> + p.x_multifd_threads = valueint;
> }
See also commit bb2b777 as a regression fix for a missing use_int_value.
> +++ b/qapi-schema.json
> @@ -665,13 +665,16 @@
> # @downtime-limit: set maximum tolerated downtime for migration. maximum
> # downtime in milliseconds (Since 2.8)
> #
> +# @x-multifd-threads: Number of threads used to migrate data in parallel
> +# The default value is 1 (since 2.8)
> +#
> # Since: 2.4
> ##
> { 'enum': 'MigrationParameter',
> 'data': ['compress-level', 'compress-threads', 'decompress-threads',
> 'cpu-throttle-initial', 'cpu-throttle-increment',
> 'tls-creds', 'tls-hostname', 'max-bandwidth',
> - 'downtime-limit'] }
> + 'downtime-limit', 'x-multifd-threads'] }
>
> #
> # @migrate-set-parameters
> @@ -726,6 +729,9 @@
> # @downtime-limit: set maximum tolerated downtime for migration. maximum
> # downtime in milliseconds (Since 2.8)
> #
> +# @x-multifd-threads: Number of threads used to migrate data in parallel
> +# The default value is 1 (since 2.8)
Pre-existing in the other parameters, but we have an inconsistent use of
#optional markers here.
> +#
> # Since: 2.4
> ##
> { 'struct': 'MigrationParameters',
> @@ -737,7 +743,8 @@
> '*tls-creds': 'str',
> '*tls-hostname': 'str',
> '*max-bandwidth': 'int',
> - '*downtime-limit': 'int'} }
> + '*downtime-limit': 'int',
> + '*x-multifd-threads': 'int'} }
> ##
> # @query-migrate-parameters
> #
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC 00/13] Multifd v2, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 02/13] migration: [HACK] Don't create decompression threads if not enabled, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 03/13] migration: Add multifd capability, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads parameter, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 01/13] migration: create Migration Incoming State at init time, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 05/13] migration: create multifd migration threads, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 06/13] migration: Start of multiple fd work, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 07/13] migration: create ram_multifd_page, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 09/13] migration: Send the fd number which we are going to use for this page, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 08/13] migration: Create thread infrastructure for multifd send side, Juan Quintela, 2016/10/21
- [Qemu-devel] [PATCH 11/13] migration: Test new fd infrastructure, Juan Quintela, 2016/10/21