qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] gtk: fix compilation warning with gtk 3.22.2


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] gtk: fix compilation warning with gtk 3.22.2
Date: Thu, 27 Oct 2016 13:50:44 +0200

On Mi, 2016-10-26 at 17:35 +0200, Alberto Garcia wrote:
> On Wed 26 Oct 2016 05:21:08 PM CEST, Alberto Garcia wrote:
> > +#else
> > +        {
> > +            screen_width = gdk_screen_get_width(screen);
> > +            screen_height = gdk_screen_get_height(screen);
> > +        }
> > +#endif
> 
> I forgot to remove these braces, they are actually not necessary, so
> whoever applies the patch can remove them if they want. I don't mind if
> we keep them for clarity, though, I'm fine either way.

Taking patch as-is, I find it more readable with the braces.

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]