[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use &error_ab
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use &error_abort to catch errors |
Date: |
Thu, 27 Oct 2016 16:16:43 +0200 |
On Wed, 26 Oct 2016 14:30:20 -0200
Eduardo Habkost <address@hidden> wrote:
> Use &error_abort so we don't ignore any errors on the property
> registration calls.
a similar patch for other *property_add* calls in that file
would be nice addition on top, so *property_add* calls would
be treated consistently.
>
> Reviewed-by: Andreas Färber <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> tests/check-qom-proplist.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
> index 693dc4c..a92acc9 100644
> --- a/tests/check-qom-proplist.c
> +++ b/tests/check-qom-proplist.c
> @@ -123,7 +123,7 @@ static void dummy_init(Object *obj)
> object_property_add_bool(obj, "bv",
> dummy_get_bv,
> dummy_set_bv,
> - NULL);
> + &error_abort);
> }
>
>
> @@ -132,13 +132,13 @@ static void dummy_class_init(ObjectClass *cls, void
> *data)
> object_class_property_add_str(cls, "sv",
> dummy_get_sv,
> dummy_set_sv,
> - NULL);
> + &error_abort);
> object_class_property_add_enum(cls, "av",
> "DummyAnimal",
> dummy_animal_map,
> dummy_get_av,
> dummy_set_av,
> - NULL);
> + &error_abort);
> }
>
>
- [Qemu-devel] [PATCH v3 0/8] qdev class properties + abstract class support on device-list-properties, Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property, Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use &error_abort to catch errors, Eduardo Habkost, 2016/10/26
- Re: [Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use &error_abort to catch errors,
Igor Mammedov <=
- [Qemu-devel] [PATCH v3 4/8] qdev: Extract property-default code to qdev_property_set_to_default(), Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 6/8] qom: object_class_property_iter_init() function, Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties, Eduardo Habkost, 2016/10/26