qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 08/18] tcg/mips: Implement field extraction o


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 08/18] tcg/mips: Implement field extraction opcodes
Date: Thu, 27 Oct 2016 07:19:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 10/27/2016 06:40 AM, Yongbok Kim wrote:
> +    case INDEX_op_extract_i32:
> +        tcg_out_opc_bf(s, OPC_EXT, a0, a1, a3 + args[3] - 1, a2);
The msbd (5th argument) must be (a2 + args[3] - 1). In fact "a3" isn't defined.


Yes, I eventually caught this typo when I finally got around to the cross-compile. Thanks.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]