qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99


From: G 3
Subject: Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99
Date: Thu, 27 Oct 2016 11:12:44 -0400


On Oct 27, 2016, at 11:07 AM, Gerd Hoffmann wrote:

+# needed to make gcc accept wide unicode chars without warning
+curses.o-cflags := -std=gnu99

Could we add a commit message to this patch? It could answer
questions like:

Why this patch is needed?
Who needs this patch?
What problem it solves.

The comment added by the patch explains things.

I could cut+paste that into the commit msg, but given how small the
patch is it looked pointless to me ...

cheers,
  Gerd

A commit message should go with every patch. It makes it easier for someone looking thru the commit history to understand your patch.

This might be good enough:

Makes gcc accept wide unicode characters without producing a warning during compilation.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]