[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 1637447] Re: VNC/RFB: QEMU reports incorrect name (len
From: |
Jakob van Kruijssen |
Subject: |
[Qemu-devel] [Bug 1637447] Re: VNC/RFB: QEMU reports incorrect name (length) |
Date: |
Fri, 28 Oct 2016 09:57:48 -0000 |
** Description changed:
If the name of a machine (as set with the -name argument) has a length
longer than 1024, (RFB) VNC clients will not receive a correct RFB
ServerInit message.
I suspect this is the problem:
- https://github.com/qemu/qemu/blob/master/ui/vnc.c#L2463
+ https://github.com/qemu/qemu/blob/v2.7.0-rc5/ui/vnc.c#L2459
The return value of snprintf is used as the value for the name-length field
in the ServerInit message.
This is problematic for names that were truncated to 1024, as the length will
now be bigger than the actual name.
I think a quick fix would be to simply report min(size,1024) to the
client...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1637447
Title:
VNC/RFB: QEMU reports incorrect name (length)
Status in QEMU:
New
Bug description:
If the name of a machine (as set with the -name argument) has a length
longer than 1024, (RFB) VNC clients will not receive a correct RFB
ServerInit message.
I suspect this is the problem:
https://github.com/qemu/qemu/blob/v2.7.0-rc5/ui/vnc.c#L2459
The return value of snprintf is used as the value for the name-length field
in the ServerInit message.
This is problematic for names that were truncated to 1024, as the length will
now be bigger than the actual name.
I think a quick fix would be to simply report min(size,1024) to the
client...
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1637447/+subscriptions