[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/20] qemu-img: call aio_context_acquire/release aro
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PULL 16/20] qemu-img: call aio_context_acquire/release around block job |
Date: |
Fri, 28 Oct 2016 22:49:21 +0800 |
From: Paolo Bonzini <address@hidden>
This will be needed by bdrv_reopen_multiple, which calls
bdrv_drain_all and thus will *release* the AioContext.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
---
qemu-img.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/qemu-img.c b/qemu-img.c
index afcd51f..ac7f40d 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -795,6 +795,7 @@ static void run_block_job(BlockJob *job, Error **errp)
{
AioContext *aio_context = blk_get_aio_context(job->blk);
+ aio_context_acquire(aio_context);
do {
aio_poll(aio_context, true);
qemu_progress_print(job->len ?
@@ -802,6 +803,7 @@ static void run_block_job(BlockJob *job, Error **errp)
} while (!job->ready);
block_job_complete_sync(job, errp);
+ aio_context_release(aio_context);
/* A block job may finish instantaneously without publishing any progress,
* so just signal completion here */
@@ -819,6 +821,7 @@ static int img_commit(int argc, char **argv)
Error *local_err = NULL;
CommonBlockJobCBInfo cbi;
bool image_opts = false;
+ AioContext *aio_context;
fmt = NULL;
cache = BDRV_DEFAULT_CACHE;
@@ -928,8 +931,11 @@ static int img_commit(int argc, char **argv)
.bs = bs,
};
+ aio_context = bdrv_get_aio_context(bs);
+ aio_context_acquire(aio_context);
commit_active_start("commit", bs, base_bs, 0, BLOCKDEV_ON_ERROR_REPORT,
common_block_job_cb, &cbi, &local_err, false);
+ aio_context_release(aio_context);
if (local_err) {
goto done;
}
--
2.7.4
- [Qemu-devel] [PULL 06/20] qed: Implement .bdrv_drain, (continued)
- [Qemu-devel] [PULL 06/20] qed: Implement .bdrv_drain, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 07/20] block: introduce BDRV_POLL_WHILE, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 09/20] nfs: use BDRV_POLL_WHILE, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 08/20] nfs: move nfs_set_events out of the while loops, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 11/20] aio: introduce qemu_get_current_aio_context, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 10/20] sheepdog: use BDRV_POLL_WHILE, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 12/20] iothread: detach all block devices before stopping them, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 13/20] replication: pass BlockDriverState to reopen_backing_file, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 14/20] block: prepare bdrv_reopen_multiple to release AioContext, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 15/20] qemu-io: acquire AioContext, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 16/20] qemu-img: call aio_context_acquire/release around block job,
Fam Zheng <=
- [Qemu-devel] [PULL 18/20] iothread: release AioContext around aio_poll, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 17/20] block: only call aio_poll on the current thread's AioContext, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 19/20] qemu-thread: introduce QemuRecMutex, Fam Zheng, 2016/10/28
- [Qemu-devel] [PULL 20/20] aio: convert from RFifoLock to QemuRecMutex, Fam Zheng, 2016/10/28
- Re: [Qemu-devel] [PULL 00/20] Block patches, Peter Maydell, 2016/10/31