[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/8] acpi nvdimm: fix device physical address base
From: |
Xiao Guangrong |
Subject: |
[Qemu-devel] [PATCH 2/8] acpi nvdimm: fix device physical address base |
Date: |
Sat, 29 Oct 2016 00:11:50 +0800 |
According to ACPI 6.0 spec, "Memory Device Physical Address
Region Base" in memdev is defined as "This field provides the
Device Physical Address base of the region". This field should
be zero in our case
Signed-off-by: Xiao Guangrong <address@hidden>
---
hw/acpi/nvdimm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 24a2b3b..05fdf9c 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -289,8 +289,6 @@ static void
nvdimm_build_structure_memdev(GArray *structures, DeviceState *dev)
{
NvdimmNfitMemDev *nfit_memdev;
- uint64_t addr = object_property_get_int(OBJECT(dev), PC_DIMM_ADDR_PROP,
- NULL);
uint64_t size = object_property_get_int(OBJECT(dev), PC_DIMM_SIZE_PROP,
NULL);
int slot = object_property_get_int(OBJECT(dev), PC_DIMM_SLOT_PROP,
@@ -314,7 +312,8 @@ nvdimm_build_structure_memdev(GArray *structures,
DeviceState *dev)
/* The memory region on the device. */
nfit_memdev->region_len = cpu_to_le64(size);
- nfit_memdev->region_dpa = cpu_to_le64(addr);
+ /* The device address starts from 0. */
+ nfit_memdev->region_dpa = cpu_to_le64(0);
/* Only one interleave for PMEM. */
nfit_memdev->interleave_ways = cpu_to_le16(1);
--
1.8.3.1
- [Qemu-devel] [PATCH 0/8] nvdimm acpi: bug fix and cleanup, Xiao Guangrong, 2016/10/28
- [Qemu-devel] [PATCH 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method, Xiao Guangrong, 2016/10/28
- [Qemu-devel] [PATCH 2/8] acpi nvdimm: fix device physical address base,
Xiao Guangrong <=
- [Qemu-devel] [PATCH 3/8] acpi nvdimm: fix OperationRegion definition, Xiao Guangrong, 2016/10/28
- [Qemu-devel] [PATCH 4/8] acpi nvdimm: fix ARG3 conflict, Xiao Guangrong, 2016/10/28
- [Qemu-devel] [PATCH 5/8] acpi nvdimm: fix Arg6 usage, Xiao Guangrong, 2016/10/28
- [Qemu-devel] [PATCH 6/8] nvdimm acpi: compile nvdimm acpi code arch-independently, Xiao Guangrong, 2016/10/28
- [Qemu-devel] [PATCH 7/8] acpi nvdimm: rename result_size to dsm_out_buf_siz, Xiao Guangrong, 2016/10/28
- [Qemu-devel] [PATCH 8/8] nvdimm acpi: use common macros instead of magic names, Xiao Guangrong, 2016/10/28